·1 min read
On Code Reviews
developmentcraft
The worst code review I ever received was 400 comments on a 200-line pull request. Every variable name questioned. Every architecture decision challenged. It took three days to address.
The best code review I ever received was two comments: Does this handle the case where the user has no projects? and Should this be a separate function?
Both were useful. Only one made me a better engineer.
Good code reviews are not about catching bugs. Bugs get caught in production anyway. Good code reviews are about transferring knowledge, building shared understanding, and asking the questions the author was too close to the code to see.
The goal is not to be right. The goal is to make the code right.
The best code review I ever received was two comments: Does this handle the case where the user has no projects? and Should this be a separate function?
Both were useful. Only one made me a better engineer.
Good code reviews are not about catching bugs. Bugs get caught in production anyway. Good code reviews are about transferring knowledge, building shared understanding, and asking the questions the author was too close to the code to see.
The goal is not to be right. The goal is to make the code right.